Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nav): Nav collapses when links are clicked on mobile MAASENG-2384 #5345

Merged
merged 4 commits into from
Mar 13, 2024
Merged

fix(nav): Nav collapses when links are clicked on mobile MAASENG-2384 #5345

merged 4 commits into from
Mar 13, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Mar 13, 2024 •
edited by Jay-Topher
Loading

Done

  • Navigation will now collapse automatically when a link is clicked (on mobile)
  • Added a cypress test to ensure this functionality

QA steps

With a desktop viewport size:

  • Click the navigation "expand" button
  • Click a nav link
  • Ensure the navigation does not collapse

With a mobile viewport size:

  • Click the "Menu" button in the header
  • Click a nav link
  • Ensure the navigation collapses

Fixes

Fixes MAASENG-2384

@webteam-app
Copy link

Demo starting at https://maas-ui-5345.demos.haus

@ndv99 ndv99 merged commit 4458985 into canonical:main Mar 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermakowski petermakowski petermakowski approved these changes

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndv99 @webteam-app @petermakowski @Jay-Topher